Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Is it possible to set 'Access-Control-Allow-Origin' on /primus endpoint? #142

Closed
tombburnell opened this Issue Jan 30, 2014 · 5 comments

Comments

Projects
None yet
3 participants

No description provided.

Owner

3rd-Eden commented Jan 31, 2014

It's something that I do want to implement for every request, but I haven't gotten around doing it yet. I know that it's that will be causing a lot of issues when we get it wrong.

Contributor

zemirco commented Feb 12, 2014

+1 for setting Access-Control-Allow-Origin header

Owner

3rd-Eden commented Mar 6, 2014

Bumped priority, gonna write a dedicated module for this as correctly setting and handling these headers is a delicate matter as there have been ALOT of bugs in Socket.IO that we're caused by incorrectly setting of these headers.

Owner

3rd-Eden commented Mar 10, 2014

Decided to write a completely new CORS module in order to support this feature. The current modules and their code quality are no up to my standards or are simply not following the specifications. The module is developed at: https://github.com/primus/access-control and once all tests pass, it would be as simple as adding one single function call to implement this feature. So it would be safe to say that this feature will land in our next release. Which will be 2.1.0 as this brings a major new feature.

Contributor

zemirco commented Mar 10, 2014

sounds awesome!

@3rd-Eden 3rd-Eden added this to the 2.1 milestone Mar 14, 2014

@3rd-Eden 3rd-Eden referenced this issue Mar 19, 2014

Merged

Cors #178

@3rd-Eden 3rd-Eden closed this in #178 Mar 19, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment