New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] Add custom spark id generator option. Closes #551 #601

Merged
merged 3 commits into from Jul 22, 2017

Conversation

Projects
None yet
2 participants
@nanowizard
Contributor

nanowizard commented Jul 22, 2017

Signed-off-by: Ryan Sivek nanowizardry@gmail.com

[feature] Add custom spark id generator option
Signed-off-by: Ryan Sivek <nanowizardry@gmail.com>
@lpinca

lpinca approved these changes Jul 22, 2017

Show outdated Hide outdated test/primus.test.js
Show outdated Hide outdated test/primus.test.js

nanowizard added some commits Jul 22, 2017

Move test to spark tests and simplify
Signed-off-by: Ryan Sivek <nanowizardry@gmail.com>
[minor] Remove unnecessary expect clause from test
Signed-off-by: Ryan Sivek <nanowizardry@gmail.com>

@lpinca lpinca merged commit 93ca015 into primus:master Jul 22, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@lpinca

This comment has been minimized.

Show comment
Hide comment
@lpinca

lpinca Jul 22, 2017

Member

Thank you!

Member

lpinca commented Jul 22, 2017

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment