New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed content-disposition error that occurs with filename set and new chrome version #16

Closed
wants to merge 113 commits into
base: master
from

Conversation

Projects
None yet
@rylwin

rylwin commented Dec 16, 2011

This fixes an issue where new version of Chrome 16.0.912.63 would give this error when passing a filename to prawnto:

Error 349 (net::ERR_RESPONSE_HEADERS_MULTIPLE_CONTENT_DISPOSITION): Multiple
Content-Disposition headers received. This is disallowed to protect against HTTP
response splitting attacks

This error was resolved by wrapping the filename in the content-disposition header in quotes.
WAS: "Content-Disposition"=>"attachment;filename=Name of your file.pdf"

NOW: "Content-Disposition"=>"attachment;filename="Name of your file.pdf""

mocoso and others added some commits Mar 20, 2009

Fix the method of determining whether the request is SSL or not. The …
…way that it was done would error out in functional tests because env['SERVER_PROTOCOL'] would be nil. More importantly, this would not necessarily return true even if the request was an ssl request. Resolves #3.
Fixed bug with default :inline => false option.
When we define it as false at class level, option always overrided by default true value
and prawnto always set disposition-type as "inline" instead of "attachment".
Fixed bug with default :inline => false option.
When we define it as false at class level, option always overrided by default true value
and prawnto always set disposition-type as "inline" instead of "attachment".
Fix the method of determining whether the request is SSL or not. The …
…way that it was done would error out in functional tests because env['SERVER_PROTOCOL'] would be nil. More importantly, this would not necessarily return true even if the request was an ssl request. Resolves #3.
Remove empty prawnto tasks
Because they were causing deprecation warnings

forrest and others added some commits Jan 22, 2012

Merge branch 'master' of http://github.com/forrest/prawnto
* 'master' of http://github.com/forrest/prawnto: (93 commits)
  Readme cleanup & Version bump
  Adding warning message for redefining 'pdf' in templates
  Reminving beta from readme
  0.2.0 Stable
  0.2.0.beta6 - Hopefully this hits the mark.
  Fixing bug with blocks being past into missing methods.
  Still tweaking variable exchange methods
  0.2.0.beta5
  Fixing instance variable problem
  0.2.0.beta4
  Fixing dumb typo in travis image
  Adding travis for continuous testing.
  Fixing up ModelRenderer format ambiguity.
  0.2.0.beta3
  0.2.0.beta3
  Refactoring some files.
  ModelRenderer is working.
  Removing un-needed return of self
  Fixing install instructions in README for beta2
  Merging regular and DSL template handlers into a single super handler. 0.2.0.Beta2
  ...

Conflicts:
	lib/prawnto/template_handler/compile_support.rb
	test/base_template_handler_test.rb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment