New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

data.table dependency #18

Closed
DanRosauer opened this Issue Jul 28, 2017 · 4 comments

Comments

Projects
None yet
3 participants
@DanRosauer
Copy link

DanRosauer commented Jul 28, 2017

Running a line such as
p <- marxan_problem("input_sp.dat")

Returns the error:
Error in load_file("PUNAME", x, input_dir) : the "data.table" package needs to be installed to load Marxan data files.

Could you make data.table a dependency, so it gets installed automatically?

(please ignore if it is already, but install happened to fail in this case)

@jeffreyhanson

This comment has been minimized.

Copy link
Contributor

jeffreyhanson commented Jul 28, 2017

Thanks for raising this issue!

Yeah, so originally we listed data.table under Suggests and not Imports is because data.table is only used in the marxan_problem function, and data.table can take a while to install, so I thought users might appreciate not having to install data.table if they don't need it.

What do you think? Do you think people would rather have data.table installed automatically even if it meant that they may not use it?

@DanRosauer

This comment has been minimized.

Copy link

DanRosauer commented Jul 28, 2017

R packages often install lots of dependencies which are only needed for some function you would never use... So I can see the point of being more selective - fair point. It is nice though to install a package, and it all just works.... Up to you.

@ricschuster

This comment has been minimized.

Copy link
Member

ricschuster commented Jul 28, 2017

Thanks for raising this Dan.
@jeffreyhanson, as data.table isn't that large a package, why don't we just move it to the Imports?

@jeffreyhanson

This comment has been minimized.

Copy link
Contributor

jeffreyhanson commented Sep 27, 2017

I've added the data.table package to Imports in version 1.0.2.0 (e01c77e)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment