New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow marxan_problem to use the INPUTDIR argument in the Marxan param file #19

Closed
DanRosauer opened this Issue Jul 28, 2017 · 6 comments

Comments

Projects
None yet
2 participants
@DanRosauer
Copy link

DanRosauer commented Jul 28, 2017

The marxan parameter file - usually input.dat - has an INPUTDIR argument for the input directory, but I understand that marxan_problem() is constrained to using a directory directly below the location of the Marxan input file.

Could INPUTDIR and OUTPUTDIR be allowed to specify any paths?

An advantage of allowing any directory to be specified, is that many problems can then be run from the same input data. For large projects with many problem variants, this can be a major saving of space and complexity.

@jeffreyhanson

This comment has been minimized.

Copy link
Contributor

jeffreyhanson commented Sep 29, 2017

Sorry for the late reply, I've got a small amount of time up my sleeve at the moment so I'm trying to address some prioritizr issues.

I just want to double check that I understand correctly. Is the issue that it doesn't allow Marxan input.dat files with complete file paths? For example, something like: C:\Users\jhanson\Downloads?

If so, should the file name fields (eg. SPECNAME , PUNAME) also allow complete paths?

@jeffreyhanson

This comment has been minimized.

Copy link
Contributor

jeffreyhanson commented Sep 29, 2017

Also, I don't think prioritizr does anything with OUTPUTDIR. Would you like to see prioritizr save output files similar to Marxan?

@jeffreyhanson

This comment has been minimized.

Copy link
Contributor

jeffreyhanson commented Sep 29, 2017

The following commit will enable absolute file paths in INPUTDIR, SPECNAME, PUNAME and etc. Please re-open this issue if I have misinterpreted the nature of the issue.

@DanRosauer

This comment has been minimized.

Copy link

DanRosauer commented Sep 29, 2017

@DanRosauer

This comment has been minimized.

Copy link

DanRosauer commented Sep 29, 2017

@jeffreyhanson

This comment has been minimized.

Copy link
Contributor

jeffreyhanson commented Sep 29, 2017

Ok, I think I've addressed the issue with the regarding the absolute file paths. Feel free to reopen this issue if it's still not working. I haven't properly tested it on Windows, but it works on Ubuntu.

I'll make another issue with Marxan outputs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment