New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testthat version update #34

Closed
jeffreyhanson opened this Issue Oct 18, 2017 · 1 comment

Comments

Projects
None yet
2 participants
@jeffreyhanson
Copy link
Contributor

jeffreyhanson commented Oct 18, 2017

I received an automated email notifying me that a new version of the testthat R package will be made available on CRAN on November 13th. Apparently, the new version will change the behaviour of testthat's functions such that code that currently works will fail upon the release of the new version. As a consequence, the unit tests in prioritizr will need to be rewritten to be compatible with the new version of testthat. Also, we should probably hold off on submitting prioritizr to CRAN until the new version of testthat is on CRAN to avoid having to do multiple submission in a short period of time.

@jeffreyhanson jeffreyhanson added this to the CRAN Release milestone Oct 18, 2017

@jeffreyhanson jeffreyhanson changed the title testthat version 2.0 testthat version update Oct 18, 2017

@ricschuster

This comment has been minimized.

Copy link
Member

ricschuster commented Oct 19, 2017

Thanks for bringing this up Jeff. I'm happy to hold off with submitting prioritizr until the new version of testthat is out and prioritizr is rewritten.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment