New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

velox package dependency #8

Closed
ricschuster opened this Issue Mar 29, 2017 · 2 comments

Comments

Projects
None yet
2 participants
@ricschuster
Copy link
Member

ricschuster commented Mar 29, 2017

Should
import(velox)
be added to NAMESPACE?

p1 <- problem(sim_pu_polygons, features = sim_features, cost_name = "cost") %>%

  • add_min_set_objective() %>%
  • add_relative_targets(0.2) %>%
  • add_binary_decisions()
    Loading required namespace: velox
    Failed with error: ‘there is no package called ‘velox’’

mstrimas added a commit that referenced this issue Mar 29, 2017

@mstrimas

This comment has been minimized.

Copy link
Contributor

mstrimas commented Mar 29, 2017

velox is meant to be an optional package, the issue was just that one of the requireNamespace("velox") calls was missing a quietly = TRUE, which I've now fixed. It was sort of a phantom error because the code actually runs just fine despite the error.

@ricschuster

This comment has been minimized.

Copy link
Member

ricschuster commented Mar 29, 2017

Thanks @mstrimas

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment