Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document thenable nature of Prisma Client queries #1695

Open
janpio opened this issue May 12, 2021 · 5 comments · Fixed by #2005
Open

Document thenable nature of Prisma Client queries #1695

janpio opened this issue May 12, 2021 · 5 comments · Fixed by #2005
Labels
docs Documentation creation, updates or corrections

Comments

@janpio
Copy link
Member

janpio commented May 12, 2021

prisma/prisma#7033 + https://prisma-company.slack.com/archives/CUXLS0Z6K/p1620760435005700
@janpio janpio added the docs Documentation creation, updates or corrections label May 12, 2021
@mhwelander
Copy link
Contributor

Related, I think: #800

@mhwelander
Copy link
Contributor

https://prisma-company.slack.com/archives/CUXLS0Z6K/p1622119096024300

@mhwelander mhwelander self-assigned this May 28, 2021
@janpio
Copy link
Member Author

janpio commented Jun 21, 2021

Additional context how this is not the case for $connect() and $disconnect(): https://prisma-company.slack.com/archives/C016KUHB1R6/p1623999600168300

@mhwelander mhwelander removed their assignment Jun 23, 2021
@molebox molebox mentioned this issue Jul 8, 2021
Merged
@molebox molebox self-assigned this Jul 8, 2021
@Jolg42
Copy link
Member

Jolg42 commented Jul 9, 2021

@molebox In the PR it could be misunderstood that all client methods are thenable but actually it's all except $connect() and $disconnect()

@Jolg42 Jolg42 reopened this Jul 9, 2021
@Jolg42
Copy link
Member

Jolg42 commented Jul 9, 2021 •
edited by janpio

Actually there are also $on() and $use() that don't fit the thenable description.

Better to say maybe:
The following methods are thenable (...)

  • All model queries like .create(). .update() ....
  • $executeRaw()
  • $queryRaw()
  • $transaction()

@Jolg42 Jolg42 mentioned this issue Sep 2, 2022
Open
@janpio janpio removed the team/client label Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
docs Documentation creation, updates or corrections
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Document queries thenable prisma/docs
6 participants
@janpio @thebiglabasky @mhwelander @Jolg42 @molebox @meletj