-
Notifications
You must be signed in to change notification settings - Fork 854
feat: add deprecation warning for metrics #7151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughUpdates the Prisma metrics documentation: replaces the initial info block with a standardized info + deprecation warning tied to Prisma ORM v6.14.0 (removal in v7); restricts metrics to Prisma ≤6.13.x; blocks metrics when Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Comment |
Dangerous URL checkNo absolute URLs to prisma.io/docs found. |
Redirect checkThis PR probably requires the following redirects to be added to static/_redirects:
|
Deploying docs with
|
| Latest commit: |
32e2ff5
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://9f9f42c2.docs-51g.pages.dev |
| Branch Preview URL: | https://dc-5528-metrics-deprecation.docs-51g.pages.dev |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🧹 Nitpick comments (1)
content/200-orm/200-prisma-client/600-observability-and-logging/240-metrics.mdx (1)
20-24: Remove removal-version mention from the warning.The docs style guide says deprecation notices should name the version where the feature was deprecated but must not promise a future removal version, because plans change and become outdated quickly. Please drop the “will be removed in Prisma ORM v7” sentence from this block to stay compliant. As per coding guidelines.(prisma.io)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
content/200-orm/200-prisma-client/600-observability-and-logging/240-metrics.mdx(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
- GitHub Check: Check internal links
- GitHub Check: runner / linkspector
- GitHub Check: Lost Pixel
- GitHub Check: Cloudflare Pages
content/200-orm/200-prisma-client/600-observability-and-logging/240-metrics.mdx
Show resolved
Hide resolved
|
@ankur-arch can we also add a note that it is not supported at all when using |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
content/200-orm/200-prisma-client/600-observability-and-logging/240-metrics.mdx (1)
74-83: Align the install step heading with the compatibility guidance.The list link already says “Install compatible…”, but the anchor slug and heading still read “up-to-date”. Renaming both keeps the messaging consistent and prevents broken anchors once the slug updates.
-1. [Install compatible Prisma ORM dependencies](#1-install-up-to-date-prisma-orm-dependencies). +1. [Install compatible Prisma ORM dependencies](#1-install-compatible-prisma-orm-dependencies). ... -### 1. Install up-to-date Prisma ORM dependencies +### 1. Install compatible Prisma ORM dependencies
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
content/200-orm/200-prisma-client/600-observability-and-logging/240-metrics.mdx(2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
- GitHub Check: runner / linkspector
- GitHub Check: Check internal links
- GitHub Check: Lost Pixel
- GitHub Check: Cloudflare Pages
Summary by CodeRabbit