Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken tracing UI #723

Merged
merged 1 commit into from Jun 5, 2018
Merged

Conversation

PavelGavlik
Copy link
Contributor

  • missing prop was preventing rendering of tracing results
  • Message "Please re-run the query to show tracing results." was shown even though results were available

- missing prop was preventing rendering of tracing results
- Message "Please re-run the query to show tracing results." was shown even though results were available
@CLAassistant
Copy link

CLAassistant commented Jun 4, 2018

CLA assistant check
All committers have signed the CLA.

Copy link
Collaborator

@huv1k huv1k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice good catch :) Just tested it and works

@huv1k huv1k merged commit 8158c88 into graphql:master Jun 5, 2018
@huv1k
Copy link
Collaborator

huv1k commented Jun 5, 2018

Thx for the first contribution to the playground ❤️

@PavelGavlik
Copy link
Contributor Author

Thank you for merging this so quickly!

@Ponjimon
Copy link

Hey, I just noticed this bug in my local installation of Playground, update check says there is no update so I assume this hasn't been pushed yet. Any ETA?

@huv1k
Copy link
Collaborator

huv1k commented Jun 13, 2018

@lookapanda 1-2 days :) We will release it after we merge #733

@benwaffle
Copy link
Contributor

I'm on v1.6.1 and this bug does not seem to be fixed.

cgxxv pushed a commit to cgxxv/graphql-playground that referenced this pull request Mar 25, 2022
- missing prop was preventing rendering of tracing results
- Message "Please re-run the query to show tracing results." was shown even though results were available
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants