Skip to content

feat: introduce explicit allow prompts for custom binaries #750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Mar 25, 2021

Conversation

pantharshit00
Copy link
Contributor

@pantharshit00 pantharshit00 commented Mar 24, 2021

TODOS:

  • Allowlist for custom bins
  • Reask for validation on settings change
  • Add option to reset the current binary's status (prisma.resetCurrentFmtBinDecision option)
  • Add option to reset the whole allowList (prisma.resetAllBinDecisions option)
  • Basic Tests

Copy link
Contributor

@carmenberndt carmenberndt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Jolg42 Jolg42 added this to the 2.20.0 milestone Mar 24, 2021
pantharshit00 and others added 2 commits March 24, 2021 22:14
Co-authored-by: Joël Galeran <Jolg42@users.noreply.github.com>
Co-authored-by: Joël Galeran <Jolg42@users.noreply.github.com>
@pantharshit00
Copy link
Contributor Author

Ready for merge from my end now

@janpio
Copy link
Contributor

janpio commented Mar 24, 2021

I still would prefer a slightly modified message: #750 (comment)

Co-authored-by: Jan Piotrowski <piotrowski+github@gmail.com>
@pantharshit00
Copy link
Contributor Author

Ah I didn't press commit on that, thanks for reviewing!

@janpio
Copy link
Contributor

janpio commented Mar 24, 2021

Looks good from my side, @Jolg42 and @carmenberndt should take another look at the code.
Please update the PR title to something more descriptive before mergin.

@pantharshit00 pantharshit00 changed the title feat: initial work on validator feat: introduce allow explicit allow prompts for custom binaries Mar 24, 2021
@pantharshit00 pantharshit00 changed the title feat: introduce allow explicit allow prompts for custom binaries feat: introduce explicit allow prompts for custom binaries Mar 24, 2021
Copy link
Contributor

@Jolg42 Jolg42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added suggestions to merge, looks good to me after that, well done!

pantharshit00 and others added 2 commits March 25, 2021 17:20
Co-authored-by: Joël Galeran <Jolg42@users.noreply.github.com>
Co-authored-by: Joël Galeran <Jolg42@users.noreply.github.com>
@pantharshit00 pantharshit00 merged commit 94df49c into master Mar 25, 2021
@pantharshit00 pantharshit00 deleted the add-validator branch March 25, 2021 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants