New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: introduce explicit allow prompts for custom binaries #750
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Co-authored-by: Joël Galeran <Jolg42@users.noreply.github.com>
Co-authored-by: Joël Galeran <Jolg42@users.noreply.github.com>
Co-authored-by: Jan Piotrowski <piotrowski+github@gmail.com>
|
Ready for merge from my end now |
|
I still would prefer a slightly modified message: #750 (comment) |
Co-authored-by: Jan Piotrowski <piotrowski+github@gmail.com>
|
Ah I didn't press commit on that, thanks for reviewing! |
|
Looks good from my side, @Jolg42 and @carmenberndt should take another look at the code. |
Co-authored-by: carmenberndt <carmen@berndt-home.de>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added suggestions to merge, looks good to me after that, well done!
Co-authored-by: Joël Galeran <Jolg42@users.noreply.github.com>
Co-authored-by: Joël Galeran <Jolg42@users.noreply.github.com>
TODOS:
prisma.resetCurrentFmtBinDecisionoption)prisma.resetAllBinDecisionsoption)