qe: use one db per test on cockroachdb #3597
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the recommended approach.
tomhoule
force-pushed
the
qe-cockroach-database-per-test
branch
from
f6413a8
to
32ee6b9
Compare
tomhoule
force-pushed
the
qe-cockroach-database-per-test
branch
from
821b7e7
to
3d37b56
Compare
tomhoule
commented
Jan 13, 2023
| @@ -30,6 +30,7 @@ mod metrics { | |||
| Sqlite => assert_eq!(total_queries, 9), | |||
| SqlServer(_) => assert_eq!(total_queries, 15), | |||
| MongoDb(_) => assert_eq!(total_queries, 5), | |||
| ConnectorVersion::CockroachDb => assert_eq!(total_queries, 10), | |||
There was a problem hiding this comment.
I haven't dug to the bottom of this, but it would make sense for it to be from DROP DATABASE + CREATE DATABASE on test initialization becoming 1 query (instead of 2).
janpio
reviewed
Jan 13, 2023
| @@ -10,6 +10,7 @@ on: | |||
| - 'LICENSE' | |||
| - 'CODEOWNERS' | |||
| - 'renovate.json' | |||
| - 'introspection-engine/**' | |||
There was a problem hiding this comment.
That is an interesting addition - avoiding running the QE tests on IE only changes I assume?
There was a problem hiding this comment.
Yes, not reflected but it seems like a small win.
|
/shrug |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And move to GH actions.
See individual commits for details.