Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: Remove QE Tag action that is not used by PDP anymore #4528

Merged
merged 1 commit into from
Dec 7, 2023
Merged

ci: Remove QE Tag action that is not used by PDP anymore #4528

merged 1 commit into from
Dec 7, 2023

Conversation

do4gr
Copy link
Member

@do4gr do4gr commented Dec 7, 2023 •
edited

  • we're now downloading the binaries directly
  • secret can also be removed ACCELERATE_DOCKER_QE_BUILD. I don't have the permissions anymore.

@do4gr
we're now downloading the binaries directly
0d9feda 
secret can also be removed ACCELERATE_DOCKER_QE_BUILD
@do4gr do4gr requested a review from a team as a code owner December 7, 2023 08:38
@do4gr do4gr requested review from jkomyno and Druue and removed request for a team December 7, 2023 08:38
@Jolg42 Jolg42 added this to the 5.8.0 milestone Dec 7, 2023
Jolg42
Jolg42 approved these changes Dec 7, 2023
View reviewed changes
Copy link
Contributor

@Jolg42 Jolg42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That simplifies things, which is nice ✨

See Internal Slack thread

@Jolg42 Jolg42 changed the title Remove QE Tag action that is not used by PDP anymore ci: Remove QE Tag action that is not used by PDP anymore Dec 7, 2023
@Jolg42 Jolg42 merged commit 12d71c4 into main Dec 7, 2023
3 checks passed
@Jolg42 Jolg42 deleted the RemoveQEEngineTagEvent branch December 7, 2023 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jolg42 Jolg42 Jolg42 approved these changes

@jkomyno jkomyno Awaiting requested review from jkomyno jkomyno is a code owner automatically assigned from prisma/orm-rust

@Druue Druue Awaiting requested review from Druue Druue is a code owner automatically assigned from prisma/orm-rust

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
5.8.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@do4gr @Jolg42