From 06236eb31e5a370a28c0bae5288683176184a95d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jo=C3=ABl=20Galeran?= Date: Mon, 17 May 2021 09:52:16 +0200 Subject: [PATCH] fix(migrate,introspection): remove failed- .md logic (#7059) Closes https://github.com/prisma/prisma/issues/4715 --- src/packages/client/.gitignore | 1 - src/packages/migrate/.gitignore | 1 - src/packages/migrate/src/MigrateEngine.ts | 29 +-------------------- src/packages/sdk/.gitignore | 1 - src/packages/sdk/src/IntrospectionEngine.ts | 26 +----------------- 5 files changed, 2 insertions(+), 56 deletions(-) diff --git a/src/packages/client/.gitignore b/src/packages/client/.gitignore index 143f9c16f221..1b1e8174d291 100644 --- a/src/packages/client/.gitignore +++ b/src/packages/client/.gitignore @@ -15,7 +15,6 @@ src/utils/transformed-dmmf.json *-dmmf.json *-dmmf-raw.json db -failed-*.md query-engine* test.sh try-getConfig.ts diff --git a/src/packages/migrate/.gitignore b/src/packages/migrate/.gitignore index 882293fee01a..4bac77dfc7c0 100644 --- a/src/packages/migrate/.gitignore +++ b/src/packages/migrate/.gitignore @@ -5,7 +5,6 @@ dist build .DS_Store tmp/ -failed-*.md .env* pnpm-debug.log write-test diff --git a/src/packages/migrate/src/MigrateEngine.ts b/src/packages/migrate/src/MigrateEngine.ts index 3de471aa2e0d..be2a83268f32 100644 --- a/src/packages/migrate/src/MigrateEngine.ts +++ b/src/packages/migrate/src/MigrateEngine.ts @@ -337,7 +337,6 @@ export class MigrateEngine { reject(new Error(message)) } } else { - const text = this.persistError(request, this.messages.join('\n')) reject( new Error( `${chalk.redBright( @@ -348,7 +347,7 @@ export class MigrateEngine { 2, )}\nResponse: ${JSON.stringify(response, null, 2)}\n${ response.error.message - }\n\n${text}\n`, + }\n`, ), ) } @@ -375,33 +374,7 @@ export class MigrateEngine { this.lastRequest = request }) } - private persistError(request: any, message: string): string { - const filename = `failed-${request.method}-${now()}.md` - fs.writeFileSync( - filename, - `# Failed ${request.method} at ${new Date().toISOString()} -## RPC One-Liner -\`\`\`json -${JSON.stringify(request)} -\`\`\` -## RPC Input Readable -\`\`\`json -${JSON.stringify(request, null, 2)} -\`\`\` - -## Stack Trace -\`\`\`bash -${message} -\`\`\` -`, - ) - return `Wrote ${chalk.bold(filename)} with debugging information. -Please put that file into a gist and post it in Slack. -1. ${chalk.greenBright(`cat ${filename} | pbcopy`)} -2. Create a gist ${chalk.greenBright.underline(`https://gist.github.com/new`)}` - // } - } private getRPCPayload(method: string, params: any): RPCPayload { return { id: messageId++, diff --git a/src/packages/sdk/.gitignore b/src/packages/sdk/.gitignore index 80c3b08ee0bb..57cd46b9aebd 100644 --- a/src/packages/sdk/.gitignore +++ b/src/packages/sdk/.gitignore @@ -9,7 +9,6 @@ prisma-fmt* libquery* write-test sandbox -failed-* /debug.d.ts /debug.js /debug.js.map diff --git a/src/packages/sdk/src/IntrospectionEngine.ts b/src/packages/sdk/src/IntrospectionEngine.ts index 8fa901b72b4c..507b77ec4790 100644 --- a/src/packages/sdk/src/IntrospectionEngine.ts +++ b/src/packages/sdk/src/IntrospectionEngine.ts @@ -428,7 +428,6 @@ export class IntrospectionEngine { reject(new Error(message)) } } else { - const text = this.persistError(request, this.messages.join('\n')) reject( new Error( `${chalk.redBright( @@ -439,7 +438,7 @@ export class IntrospectionEngine { 2, )}\nResponse: ${JSON.stringify(response, null, 2)}\n${ response.error.message - }\n\n${text}\n`, + }\n`, ), ) } @@ -466,30 +465,7 @@ export class IntrospectionEngine { this.lastRequest = request }) } - private persistError(request: any, message: string): string { - const filename = `failed-${request.method}-${now()}.md` - const file = `# Failed ${request.method} at ${new Date().toISOString()} -## RPC One-Liner -\`\`\`json -${JSON.stringify(request)} -\`\`\` -## RPC Input Readable -\`\`\`json -${JSON.stringify(request, null, 2)} -\`\`\` - -## Stack Trace -\`\`\`bash -${message} -\`\`\` -` - fs.writeFileSync(filename, file) - return `Wrote ${chalk.bold(filename)} with debugging information. -Please put that file into a gist and post it in Slack. -1. ${chalk.greenBright(`cat ${filename} | pbcopy`)} -2. Create a gist ${chalk.greenBright.underline(`https://gist.github.com/new`)}` - } private getRPCPayload(method: string, params: any): RPCPayload { return { id: messageId++,