From 1758ff00dcb8ac4ef22ab2e7796b17c307f75aec Mon Sep 17 00:00:00 2001 From: Alexey Orlenko Date: Fri, 24 Mar 2023 00:00:50 +0100 Subject: [PATCH] test(client): enable all relevant tracing tests with mini-proxy (#18444) --- .../functional/tracing-no-sampling/tests.ts | 23 ++++++++----------- .../client/tests/functional/tracing/tests.ts | 4 +++- 2 files changed, 13 insertions(+), 14 deletions(-) diff --git a/packages/client/tests/functional/tracing-no-sampling/tests.ts b/packages/client/tests/functional/tracing-no-sampling/tests.ts index a3826e37fa90..4382724a6752 100644 --- a/packages/client/tests/functional/tracing-no-sampling/tests.ts +++ b/packages/client/tests/functional/tracing-no-sampling/tests.ts @@ -74,19 +74,16 @@ testMatrix.setupTestSuite( expect(checkQueriesHaveNotTraceparent()).toBe(true) }) - testIf(!process.env.TEST_DATA_PROXY)( - 'should perform a query and assert that no spans were generated via itx', - async () => { - await prisma.$transaction(async (prisma) => { - await prisma.user.findMany() - }) - - const spans = inMemorySpanExporter.getFinishedSpans() - - expect(spans).toHaveLength(0) - expect(checkQueriesHaveNotTraceparent()).toBe(true) - }, - ) + test('should perform a query and assert that no spans were generated via itx', async () => { + await prisma.$transaction(async (prisma) => { + await prisma.user.findMany() + }) + + const spans = inMemorySpanExporter.getFinishedSpans() + + expect(spans).toHaveLength(0) + expect(checkQueriesHaveNotTraceparent()).toBe(true) + }) }, { skipDefaultClientInstance: true, diff --git a/packages/client/tests/functional/tracing/tests.ts b/packages/client/tests/functional/tracing/tests.ts index 246fb06f0521..c12b8bfd6e46 100644 --- a/packages/client/tests/functional/tracing/tests.ts +++ b/packages/client/tests/functional/tracing/tests.ts @@ -417,7 +417,7 @@ testMatrix.setupTestSuite(({ provider }, suiteMeta, clientMeta) => { }) }) - describeIf(!clientMeta.dataProxy)('tracing on transactions', () => { + describe('tracing on transactions', () => { test('$transaction', async () => { const email = faker.internet.email() @@ -756,6 +756,7 @@ testMatrix.setupTestSuite(({ provider }, suiteMeta, clientMeta) => { }) }) + // $connect is a no-op with Data Proxy describeIf(!clientMeta.dataProxy)('tracing connect', () => { let _prisma: PrismaClient @@ -835,6 +836,7 @@ testMatrix.setupTestSuite(({ provider }, suiteMeta, clientMeta) => { }) }) + // $disconnect is a no-op with Data Proxy describeIf(!clientMeta.dataProxy)('tracing disconnect', () => { let _prisma: PrismaClient