Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better CLI output for db pull and migrate dev when using multiSchema #17311

Open
janpio opened this issue Jan 13, 2023 · 1 comment
Open

Better CLI output for db pull and migrate dev when using multiSchema #17311

janpio opened this issue Jan 13, 2023 · 1 comment
Labels
kind/improvement An improvement to existing feature and code. team/schema Issue for team Schema. topic: cli topic: drift topic: dx topic: introspection topic: multiSchema multiple schemas topic: prisma db pull CLI: prisma db pull topic: prisma migrate dev CLI: prisma migrate dev

Comments

@janpio
Copy link
Member

janpio commented Jan 13, 2023

This screenshot was taken with multiSchema and multiple schemas configured:

image

This shows multiple opportunities for improvement:

  1. Both commands output schema = "public" and not the configured schemas. In this case the schema (implicitly public) is less important here than that
  2. Introspection output could output which schemas it introspected in db pull
  3. db pull could also mention where it found how many models etc to give the user feedback that introspection of multiple schemas actually worked
  4. The drift output should equally include in which schemas it found the differences.
  5. Any mention of "schema" in the drift output on this screenshot could be revisited to clearly be made "database schema" or "Prisma schema"
@janpio janpio added kind/improvement An improvement to existing feature and code. topic: introspection topic: dx team/schema Issue for team Schema. topic: prisma db pull CLI: prisma db pull topic: drift topic: multiSchema multiple schemas labels Jan 13, 2023
@janpio janpio changed the title Better output when using multiSchema Better CLI output for db pull and migrate dev when using multiSchema Jan 13, 2023
@Jolg42
Copy link
Member

Jolg42 commented Jan 16, 2023

  1. should be done already

@Jolg42 Jolg42 added topic: prisma migrate dev CLI: prisma migrate dev topic: cli labels Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/improvement An improvement to existing feature and code. team/schema Issue for team Schema. topic: cli topic: drift topic: dx topic: introspection topic: multiSchema multiple schemas topic: prisma db pull CLI: prisma db pull topic: prisma migrate dev CLI: prisma migrate dev
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@janpio @Jolg42