This repository has been archived by the owner on Dec 14, 2023. It is now read-only.
Adding span support into structured text toHTML method #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Copied almost verbatim out of python kit Javascript isn't that clean yet, but functionality is there. Still need to figure out how qunit works, until then no tests yet :/ Also added Link.web fragment type ¯\_(ツ)_/¯
|
Works towards fixing #5 |
|
Note for code reviewers: I added a lots of that PR into the PR #7. |
|
Man I got home with the rain pouring outside and I was all ready to crank and finish up the grouping, but you just killed it. PR #7 is awesome! Thanks for helping, hope my code was useful too. |
|
It definitely was! Thanks for the enthusiasm!! :) |
|
I'm closing this since everything is done in #7. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copied almost verbatim out of python kit
Javascript isn't that clean yet, but functionality is there.
Still need to figure out how qunit works, until then no tests yet :/
Also added Link.web fragment type ¯_(ツ)_/¯
This PR is very beta, but I wanted to get something that I could use put together today. Only real functionality missing now is
Link.documentlinks and list groups.Also did some whitespace cleanup, hope you don't mind.