Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download mods filter options doesn't work without clearing the text field #2102

Closed
1 task done
EchoEllet opened this issue Feb 7, 2024 · 1 comment · Fixed by #1728
Closed
1 task done

Download mods filter options doesn't work without clearing the text field #2102

EchoEllet opened this issue Feb 7, 2024 · 1 comment · Fixed by #1728
Labels
bug Something isn't working
Milestone

Comments

@EchoEllet
Copy link

EchoEllet commented Feb 7, 2024

Operating System

macOS

Version of Prism Launcher

8.0

Version of Qt

6.6.0

Description of bug

Download mods filter options doesn't work without clearing the text field, once I change the filter options and click search it doesn't search once again, we need to clear the text field (of search query) and type it once again

Screen.Recording.2024-02-08.at.12.01.05.AM.mp4

Steps to reproduce

  1. Create a new instance with the latest version of minecraft and a mod loader (fabric or forge)
  2. Edit instance and go to Mods, then click download mods
  3. Search for a mod that is not compatible with the current version of minecraft (outdated)
  4. Change the filter options to any version and click search, you will notice that the filter options doesn't take affect

A quick way to fix it is to clear the text field and type it again, it will work

Suspected cause

I'm unfamiliar with this repo and QT in general

Simple fix: to fix this in code, the click search button should check if the filter options has changed, or re search anyway even if the search query didn't changed

This issue is unique

  • I have searched the issue tracker and did not find an issue describing my bug.
@EchoEllet EchoEllet added the bug Something isn't working label Feb 7, 2024
@Trial97
Copy link
Member

Trial97 commented Feb 7, 2024

Fixed by: #1728

@Trial97 Trial97 linked a pull request Feb 7, 2024 that will close this issue
20 tasks
@Trial97 Trial97 added this to the 9.0 milestone Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants