Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix cfOrVm prompt #195

Merged

Conversation

Sladuca
Copy link
Contributor

@Sladuca Sladuca commented Oct 18, 2023

Description

Expected behavior:
When setting up a ceremony for a circuit with >1M constraints, the CLI automatically chooses VM verification and promps the user to select and instance type.

Actual behavior:
When setting up a ceremony for a circuit with >1M constraints, the CLI automatically chooses CF verification

The reason this occurs was because we assume cfOrVM is a boolean when it's actually a string in the case that enforceVm is true. Since the string is truthy, the CLI sets it to CF verification instead of VM verification.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • I reviewed the code of conduct and contributors' guide

@Sladuca Sladuca changed the title fix: cfOrVm prompt cases on truthy value fix cfOrVm prompt Oct 18, 2023
@Sladuca
Copy link
Contributor Author

Sladuca commented Oct 18, 2023

@ctrlc03 I believe this fixes #191

@ctrlc03 ctrlc03 self-requested a review October 18, 2023 21:31
Copy link
Collaborator

@ctrlc03 ctrlc03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch!!

@ctrlc03 ctrlc03 linked an issue Oct 18, 2023 that may be closed by this pull request
@ctrlc03 ctrlc03 merged commit 40397b7 into privacy-scaling-explorations:dev Oct 18, 2023
1 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cannot select VM on setup when constraints > 1M
2 participants