Skip to content
Permalink
Browse files

Remove checkReloadListener

We also remove the hook for successful transitions.
If we ever need things to be done after successful
transitions we will readd this hook.

Closes #2127
  • Loading branch information
cornelinux committed Mar 23, 2020
1 parent 5805b52 commit 1480b2850fdf160fb131d84e80b3a947e452d1a2
@@ -113,10 +113,6 @@ angular.module("privacyideaApp")
params: oldParams
};
});
$transitions.onSuccess({},
function() {
$scope.checkReloadListeners();
});

$scope.$on('IdleStart', function () {
//debug: console.log("start idle");
@@ -511,24 +507,6 @@ angular.module("privacyideaApp")
$scope.$broadcast("piReload");
};

$scope.checkReloadListeners = function () {
/*
TODO: The a logic, that can hide the reload button.
This is not straighforward, since the current number of connected
listeners might be confusing:
connected numbers:
var currentListeners = $scope.$$listenerCount["piReload"];
When the state changes, the scope and thus the current listener is
destroyed. But the statechange-success is called, before the scope
is destroyed, so there can be two connected listeners, when
changing from a state to another state and both have a listener
defined.
*/
$scope.reloadListeners = 1;
};

});

angular.module("privacyideaApp")
@@ -96,8 +96,7 @@
<li>
<spinner name="spinner" show="false"></spinner>
</li>
<li ng-show="reloadListeners && loggedInUser.role &&
showReload">
<li ng-show="loggedInUser.role && showReload">
<a ng-click="reload()" style="cursor: pointer">
<span class="glyphicon glyphicon-refresh" aria-hidden="true"></span>
<translate>Refresh</translate>

0 comments on commit 1480b28

Please sign in to comment.
You can’t perform that action at this time.