New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow different SMS Gateways for SMS tokens #1358

Closed
cornelinux opened this Issue Dec 28, 2018 · 1 comment

Comments

Projects
None yet
1 participant
@cornelinux
Copy link
Member

cornelinux commented Dec 28, 2018

Currently the SMS gateway is defined centraly in the system config. This one SMS gateway is then used for all SMS tokens in the system.

It should be possible to choose different SMS gateways for tokens.
The Admin (or user) should be able to choose the SMS gateway that should be used for this token.
(We also should add a policy, which SMS gateway the admin or the user is allowed to choose).

During initialization of the SMS token the API call could simply add a parameter sms.identifier and use self.get_tokeninfo("sms.identifier") to read the individual SMS gateway.
If no individual SMS gateway is set, the default, system wide gateway should be used.

@cornelinux cornelinux added this to the 3.0 Code Cleanup milestone Dec 28, 2018

@cornelinux

This comment has been minimized.

Copy link
Member

cornelinux commented Jan 11, 2019

It currently already works that the UI could add a parameter sms.identifier.
THis would already be added to the tokeninfo.

What we need to do:

  • Check for the tokeninfo sms.identifier in the code
  • Add a field sms.identifier to the enrollment page
  • Add policies for users to be able to choose from selected sms gateways
  • Add policies for admins to be able to choose from selected sms gateways.

@cornelinux cornelinux self-assigned this Jan 14, 2019

cornelinux added a commit that referenced this issue Jan 14, 2019

Allow different SMS gateways
Check for a token specific gateway identifier.

Working on #1358

@plettich plettich closed this in e87b937 Jan 17, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment