Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Streamline installation and upgrade by stamping the database upon creation #1489

Open
fredreichbier opened this Issue Mar 6, 2019 · 1 comment

Comments

Projects
None yet
2 participants
@fredreichbier
Copy link
Member

fredreichbier commented Mar 6, 2019

Currently, our installation process runs pi-manage createdb to create all database tables. This is how the Ubuntu packages do it, and also how the documentation describes pip installations.

I think it would be nice if we would also stamp the database to the latest revision for fresh installations. We could do that by adding pi-manage db stamp head to the Ubuntu postinst scripts and to the documentation.

This would make future upgrades smoother: Currently, for new installations, privacyidea-schema-upgrade has to stamp the database to the first alembic revision and apply all migration scripts since then. If we initially stamp the database of fresh installations, we could skip this step.

What do you think?

@cornelinux

This comment has been minimized.

Copy link
Member

cornelinux commented Mar 11, 2019

This makes absolute sense, then we would start a new database with the right alembic version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.