Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

search_on_enter policy should also apply for audit log searches #1493

Open
stojmir opened this Issue Mar 7, 2019 · 1 comment

Comments

Projects
None yet
2 participants
@stojmir
Copy link
Contributor

stojmir commented Mar 7, 2019

What did you try to do?

Enable search_on_enter in the policy.
This successfully disables search-as-you-type for the token and user lists, however not for the audit log search boxes.

What outcome did you expect?

Intuitively, search_on_enter should apply to all search boxes in the web interface.

@cornelinux

This comment has been minimized.

Copy link
Member

cornelinux commented Mar 8, 2019

I was never convinced of this search_on_enter thing. The intention for search on enter was to prevent external network traffic, e.g. to the external LDAP server.

In case of the audit log all searches are localized on the privacyIDEA server. So I do not see any sense in doing this here.
Do you experience timeing problems with the audit log?

Maybe we should improve the documentation:
https://privacyidea.readthedocs.io/en/latest/policies/webui.html?highlight=search_on_enter#search-on-enter

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.