Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/Update requirements/setup.py #1550

Closed
plettich opened this Issue Apr 2, 2019 · 2 comments

Comments

Projects
None yet
2 participants
@plettich
Copy link
Member

commented Apr 2, 2019

Since we are going to ship virtualenvs, we should keep an eye on the requirements.
There are several packages only needed for building the docs or running the tests, we should move them to a respective requirements file.
Also some of the packages aren't used anymore, we should remove them in order to reduce the size of the virtualenv and to avoid undefined behavior.

See also #1127

@fredreichbier

This comment has been minimized.

Copy link
Member

commented Apr 2, 2019

Sounds good!

We could use the same trick as for doc/requirements.txt and create a requirements-dev.txt which lists additional development requirements:

-r requirements.txt
coverage==...

Also, we should ensure that we pin dependencies exactly in the requirements.txt. Right now, there are some exceptions:

$ grep '>=' requirements.txt 
cffi>=1.7.0
oauth2client>=2.0.1
psycopg2>=2.6
@plettich

This comment has been minimized.

Copy link
Member Author

commented Apr 9, 2019

Fixed in #1551

@plettich plettich closed this Apr 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.