Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup app config in sql audit #1639

cornelinux opened this issue May 21, 2019 · 0 comments


None yet
1 participant
Copy link

commented May 21, 2019

Some code cleanup.

The sqlaudit should use the self.config (which actualy contains the pi.cfg) and not the get_app_config_value.

--- a/privacyidea/lib/auditmodules/
+++ b/privacyidea/lib/auditmodules/
@@ -45,7 +45,6 @@ from privacyidea.lib.pooling import get_engine
 from privacyidea.lib.utils import censor_connect_string
 from privacyidea.lib.lifecycle import register_finalizer
 from privacyidea.lib.utils import truncate_comma_list
-from privacyidea.lib.framework import get_app_config_value
 from sqlalchemy import MetaData, cast, String
 from sqlalchemy import asc, desc, and_, or_
 import datetime
@@ -91,7 +90,7 @@ class Audit(AuditBase):
         self.audit_data = {}
         self.sign_data = not self.config.get("PI_AUDIT_NO_SIGN")
         self.sign_object = None
-        self.verify_old_sig = get_app_config_value('PI_CHECK_OLD_SIGNATURES')
+        self.verify_old_sig = self.config.get('PI_CHECK_OLD_SIGNATURES')
         if self.sign_data:

@cornelinux cornelinux added this to the 3.1 New Feature Release milestone May 21, 2019

cornelinux added a commit that referenced this issue Jun 14, 2019

remove dependency to the framework lib
The configuration is already contained in self.config, so we
do not need to import from the framework.

Cloeses #1639

@cornelinux cornelinux self-assigned this Jun 14, 2019

@cornelinux cornelinux changed the title Cleanup app config in sql resolver Cleanup app config in sql audit Jun 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.