Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check serial number for disallowed characters #1826

Closed
cornelinux opened this issue Aug 27, 2019 · 0 comments · Fixed by #1828

Comments

@cornelinux
Copy link
Member

commented Aug 27, 2019

Add a check utility function for allowed characters in serial numbers.
Espeically the character "/" in serial numbers could cause problems.

We maybe could add this in the decorator check_user_or_serial - if a serial is provided...

The allowed characters for OATH compatible tokens are [A-Z0-9] (see https://openauthentication.org/token-specs/)

We might start with a possible set of [a-zA-Z_\-0-9]

This refers to #1674

@cornelinux cornelinux self-assigned this Aug 27, 2019

@cornelinux cornelinux added this to the 3.2 milestone Aug 27, 2019

cornelinux added a commit that referenced this issue Aug 28, 2019
Add serial number check
The utils now get a check_serial_valid function that checks
the serial number against a regular expression.

Closes #1826
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.