Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to new dependency injection syntax #1917

Open
NuvandaPV opened this issue Nov 6, 2019 · 5 comments

Comments

@NuvandaPV
Copy link
Contributor

@NuvandaPV NuvandaPV commented Nov 6, 2019

We should replace Angular's old, deprecated dependency injection syntax with the new one.

@cornelinux

This comment has been minimized.

Copy link
Member

@cornelinux cornelinux commented Nov 7, 2019

Should we move this to milestone 3.3.?

@NuvandaPV

This comment has been minimized.

Copy link
Contributor Author

@NuvandaPV NuvandaPV commented Nov 7, 2019

I had hoped we could get this in now-ish, while there are relatively few PRs in-flight. But I can also wait until after the release, and then rebase my fork on that, if you think that would fit us better.

@cornelinux

This comment has been minimized.

Copy link
Member

@cornelinux cornelinux commented Nov 7, 2019

I am not quite up-to-speed. I remembered a concept of Paul lately and might be mistaken. Lets talk to assure that/if we put it in 3.2.

@NuvandaPV

This comment has been minimized.

Copy link
Contributor Author

@NuvandaPV NuvandaPV commented Nov 8, 2019

Sounds like a plan. Are you there Monday afternoon?

@cornelinux

This comment has been minimized.

Copy link
Member

@cornelinux cornelinux commented Nov 13, 2019

I think we decided for 3.2, now, right?

@cornelinux cornelinux modified the milestones: 3.3, 3.2 Nov 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.