Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CA testdata #1960

Closed
cornelinux opened this issue Dec 11, 2019 · 2 comments · Fixed by #1968
Closed

Update CA testdata #1960

cornelinux opened this issue Dec 11, 2019 · 2 comments · Fixed by #1968

Comments

@cornelinux
Copy link
Member

@cornelinux cornelinux commented Dec 11, 2019

Some certificates in the directory tests/testsdata/ca are about to expire in January 2020.
The CA itself is valid till 2022.
We need to check and update/renew certificates.

@cornelinux cornelinux added this to the 3.3 milestone Dec 16, 2019
@cornelinux cornelinux self-assigned this Dec 16, 2019
@cornelinux

This comment has been minimized.

Copy link
Member Author

@cornelinux cornelinux commented Dec 16, 2019

The file in question is not contained in git, but in a local directory.
We need to avoid, that this file is added to the package.
We could do a

git clean tests/testdata/ca/* -f

somewhere in during the build process.

@cornelinux

This comment has been minimized.

Copy link
Member Author

@cornelinux cornelinux commented Dec 16, 2019

All the files are created during the test run of test_lib_caconnector. I rather add a cleanup to delete these files.

cornelinux added a commit that referenced this issue Dec 16, 2019
Closes #1960
@cornelinux cornelinux added this to To do in privacyIDEA 3.3 via automation Dec 16, 2019
@cornelinux cornelinux moved this from To do to Review in progress in privacyIDEA 3.3 Dec 16, 2019
cornelinux added a commit that referenced this issue Dec 20, 2019
Incorporate review comments

Closes #1960
privacyIDEA 3.3 automation moved this from Review in progress to Done Dec 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
1 participant
You can’t perform that action at this time.