New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python3 migrate imports #1311

Merged
merged 2 commits into from Nov 15, 2018

Conversation

Projects
None yet
2 participants
@plettich
Contributor

plettich commented Nov 15, 2018

Fix the import statements to be used by Python 2 and Python 3.

Merging #1311 into master will decrease coverage by <.01%.
The diff coverage is 96.77%.
Impacted file tree graph

@@            Coverage Diff            @@
##           master   #1311      +/-   ##
=========================================
- Coverage    95.8%   95.8%   -0.01%
=========================================
Files         142     142
Lines       17238   17237       -1
=========================================
- Hits        16515   16514       -1
Misses        723     723
Impacted Files Coverage Δ
privacyidea/lib/stats.py 70.23% <100%> (ø) ⬆️
privacyidea/lib/resolver.py 96.62% <100%> (ø) ⬆️
privacyidea/lib/resolvers/PasswdIdResolver.py 99.14% <100%> (ø) ⬆️
privacyidea/lib/tokens/tiqrtoken.py 99.35% <100%> (ø) ⬆️
privacyidea/lib/realm.py 100% <100%> (ø) ⬆️
privacyidea/lib/subscriptions.py 87.7% <100%> (ø) ⬆️
privacyidea/lib/machineresolver.py 100% <100%> (ø) ⬆️
privacyidea/lib/security/__init__.py 100% <100%> (ø) ⬆️
privacyidea/lib/machines/__init__.py 100% <100%> (ø) ⬆️
privacyidea/lib/clientapplication.py 100% <100%> (ø) ⬆️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e70d8f7...070ca0b. Read the comment docs.

  

plettich added some commits Nov 7, 2018

Fixed imports for python 3
some imports changed from python 2 to python 3.
- StringIO: <https://python-future.org/compatible_idioms.html#stringio>
  Additionally since the image libraries usually write bytes into the
  stream we have to switch from StringIO to BytesIO
- urllib: <https://python-future.org/compatible_idioms.html#urllib-module>
  Some calls of the urllib functions needed an update.

@plettich plettich requested a review from privacyidea/core Nov 15, 2018

@codecov

This comment has been minimized.

codecov bot commented Nov 15, 2018

Codecov Report

Merging #1311 into master will decrease coverage by <.01%.
The diff coverage is 96.77%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #1311      +/-   ##
=========================================
- Coverage    95.8%   95.8%   -0.01%     
=========================================
  Files         142     142              
  Lines       17238   17237       -1     
=========================================
- Hits        16515   16514       -1     
  Misses        723     723
Impacted Files Coverage Δ
privacyidea/lib/stats.py 70.23% <100%> (ø) ⬆️
privacyidea/lib/resolver.py 96.62% <100%> (ø) ⬆️
privacyidea/lib/resolvers/PasswdIdResolver.py 99.14% <100%> (ø) ⬆️
privacyidea/lib/tokens/tiqrtoken.py 99.35% <100%> (ø) ⬆️
privacyidea/lib/realm.py 100% <100%> (ø) ⬆️
privacyidea/lib/subscriptions.py 87.7% <100%> (ø) ⬆️
privacyidea/lib/machineresolver.py 100% <100%> (ø) ⬆️
privacyidea/lib/security/__init__.py 100% <100%> (ø) ⬆️
privacyidea/lib/machines/__init__.py 100% <100%> (ø) ⬆️
privacyidea/lib/clientapplication.py 100% <100%> (ø) ⬆️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e70d8f7...070ca0b. Read the comment docs.

@fredreichbier fredreichbier merged commit bdfd762 into master Nov 15, 2018

5 checks passed

ci/circleci Your tests passed on CircleCI!
Details
codecov/patch 96.77% of diff hit (target 95.8%)
Details
codecov/project Absolute coverage decreased by -<.01% but relative coverage increased by +0.96% compared to e70d8f7
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@fredreichbier fredreichbier deleted the python3_migrate_imports branch Nov 15, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment