New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove audit based stats #1315

Merged
merged 2 commits into from Nov 23, 2018

Conversation

Projects
None yet
2 participants
@cornelinux
Member

cornelinux commented Nov 21, 2018

Completely remove the statistics that are audit based
and are using matplotlib and pandas.

Closes #1314

Merging #1315 into master will increase coverage by 0.14%.
The diff coverage is n/a.
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1315      +/-   ##
==========================================
+ Coverage   95.79%   95.94%   +0.14%
==========================================
Files         142      141       -1
Lines       17283    17154     -129
==========================================
- Hits        16557    16458      -99
+ Misses        726      696      -30
Impacted Files Coverage Δ
privacyidea/api/audit.py 75% <ø> (-11.21%) ⬇️
privacyidea/lib/auditmodules/base.py 100% <ø> (ø) ⬆️
privacyidea/lib/auditmodules/sqlaudit.py 96.21% <ø> (+2.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 25517b6...d2c62ab. Read the comment docs.

  

Remove audit based stats
Completely remove the statistics that are audit based
and are using matplotlib and pandas.

Closes #1314

@cornelinux cornelinux requested a review from privacyidea/core Nov 21, 2018

@codecov

This comment has been minimized.

codecov bot commented Nov 21, 2018

Codecov Report

❗️ No coverage uploaded for pull request base (master@25517b6). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1315   +/-   ##
=========================================
  Coverage          ?   96.14%           
=========================================
  Files             ?      141           
  Lines             ?    17700           
  Branches          ?        0           
=========================================
  Hits              ?    17018           
  Misses            ?      682           
  Partials          ?        0
Impacted Files Coverage Δ
privacyidea/api/audit.py 75% <ø> (ø)
privacyidea/lib/auditmodules/base.py 100% <ø> (ø)
privacyidea/lib/auditmodules/sqlaudit.py 96.21% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 25517b6...c905c19. Read the comment docs.

@fredreichbier

Looks good to me (deleting code is always fun!). I only have one minor comment.

@@ -128,10 +116,4 @@ myApp.controller("auditController", function (AuditFactory, $scope,
return true;
};

This comment has been minimized.

@fredreichbier

fredreichbier Nov 22, 2018

Member

I'm not really sure, but I think openDate can be removed too because it is unused now?

This comment has been minimized.

@cornelinux

cornelinux Nov 22, 2018

Member

I think you are right. Removed it in c905c19

@fredreichbier fredreichbier merged commit 08f7ac2 into master Nov 23, 2018

5 checks passed

ci/circleci Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected.
Details
codecov/project No report found to compare against
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@fredreichbier fredreichbier deleted the 1289/remove-old-stats branch Nov 23, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment