New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc improvements #1316

Merged
merged 3 commits into from Nov 23, 2018

Conversation

Projects
None yet
2 participants
@cornelinux
Member

cornelinux commented Nov 22, 2018

Some fixes in the documentation. Broken references and remnant files.

❗️ No coverage uploaded for pull request base (master@25517b6). Click here to learn what that means.
The diff coverage is n/a.
Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1316   +/-   ##
=========================================
Coverage          ?   95.79%
=========================================
Files             ?      142
Lines             ?    17283
Branches          ?        0
=========================================
Hits              ?    16557
Misses            ?      726
Partials          ?        0
Impacted Files Coverage Δ
privacyidea/lib/policy.py 99.4% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 25517b6...bf81556. Read the comment docs.

  •  File: doc/policies/system.rst:L0-0
  • I guess this page is obsolete now :-) Do I understand correctly that the system scope simply does not exist anymore?
  • Yes. The system scope is a remnant von LinOTP and privacyIDEA 1.5.
    Writing configurations was in the system scope. This was all moved as different actions to the admin scope.

  

@cornelinux cornelinux requested a review from privacyidea/core Nov 22, 2018

@codecov

This comment has been minimized.

codecov bot commented Nov 22, 2018

Codecov Report

❗️ No coverage uploaded for pull request base (master@25517b6). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1316   +/-   ##
=========================================
  Coverage          ?   95.79%           
=========================================
  Files             ?      142           
  Lines             ?    17283           
  Branches          ?        0           
=========================================
  Hits              ?    16557           
  Misses            ?      726           
  Partials          ?        0
Impacted Files Coverage Δ
privacyidea/lib/policy.py 99.4% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 25517b6...bf81556. Read the comment docs.

@@ -1,52 +0,0 @@
.. _system_policies:

This comment has been minimized.

@fredreichbier

fredreichbier Nov 22, 2018

Member

I guess this page is obsolete now :-) Do I understand correctly that the system scope simply does not exist anymore?

This comment has been minimized.

@cornelinux

cornelinux Nov 22, 2018

Member

Yes. The system scope is a remnant von LinOTP and privacyIDEA 1.5.
Writing configurations was in the system scope. This was all moved as different actions to the admin scope.

@fredreichbier fredreichbier merged commit ef81551 into master Nov 23, 2018

5 checks passed

ci/circleci Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected.
Details
codecov/project No report found to compare against
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@fredreichbier fredreichbier deleted the doc-improvements branch Nov 23, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment