New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Fix failing test `test_lib_utils.py`" #1317

Merged
merged 1 commit into from Nov 23, 2018

Conversation

Projects
None yet
2 participants
@plettich
Contributor

plettich commented Nov 22, 2018

This reverts commit 4ef97cc.

Basically the code was correct before, just the test was wrong.
Since we can't predict the order in which a dictionary is iterated, we
should adjust the tests accordingly.

Merging #1317 into master will decrease coverage by 0.01%.
The diff coverage is 100%.
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1317      +/-   ##
==========================================
- Coverage   95.88%   95.86%   -0.02%
==========================================
Files         142      142
Lines       17284    17285       +1
==========================================
- Hits        16572    16570       -2
- Misses        712      715       +3
Impacted Files Coverage Δ
privacyidea/lib/utils.py 96.78% <100%> (ø) ⬆️
privacyidea/lib/tokens/u2f.py 93.33% <0%> (-2.5%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 033aaaf...b9bb8db. Read the comment docs.

  

Revert "Fix failing test `test_lib_utils.py`"
This reverts commit 4ef97cc.

Basically the code was correct before, just the test was wrong.
Since we can't predict the order in which a dictionary is iterated, we
should adjust the tests accordingly.
@codecov

This comment has been minimized.

codecov bot commented Nov 22, 2018

Codecov Report

Merging #1317 into master will decrease coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1317      +/-   ##
==========================================
- Coverage   95.88%   95.86%   -0.02%     
==========================================
  Files         142      142              
  Lines       17284    17285       +1     
==========================================
- Hits        16572    16570       -2     
- Misses        712      715       +3
Impacted Files Coverage Δ
privacyidea/lib/utils.py 96.78% <100%> (ø) ⬆️
privacyidea/lib/tokens/u2f.py 93.33% <0%> (-2.5%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 033aaaf...b9bb8db. Read the comment docs.

@cornelinux cornelinux merged commit 30d8338 into master Nov 23, 2018

5 checks passed

ci/circleci Your tests passed on CircleCI!
Details
codecov/patch 100% of diff hit (target 95.88%)
Details
codecov/project Absolute coverage decreased by -0.01% but relative coverage increased by +4.11% compared to 033aaaf
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@cornelinux cornelinux deleted the python3_migrate_dicts branch Nov 23, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment