New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing API documentation #1320

Merged
merged 1 commit into from Nov 26, 2018

Conversation

Projects
None yet
3 participants
@cornelinux
Member

cornelinux commented Nov 24, 2018


Merging #1320 into master will not change coverage.
The diff coverage is 100%.
Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1320   +/-   ##
=======================================
Coverage   96.02%   96.02%
=======================================
Files         141      141
Lines       17156    17156
=======================================
Hits        16474    16474
Misses        682      682
Impacted Files Coverage Δ
privacyidea/api/caconnector.py 100% <ø> (ø) ⬆️
privacyidea/api/subscriptions.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 08f7ac2...9b58716. Read the comment docs.

  • looks good.

  

@cornelinux cornelinux requested a review from privacyidea/core Nov 24, 2018

@codecov

This comment has been minimized.

codecov bot commented Nov 24, 2018

Codecov Report

Merging #1320 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1320   +/-   ##
=======================================
  Coverage   96.02%   96.02%           
=======================================
  Files         141      141           
  Lines       17156    17156           
=======================================
  Hits        16474    16474           
  Misses        682      682
Impacted Files Coverage Δ
privacyidea/api/caconnector.py 100% <ø> (ø) ⬆️
privacyidea/api/subscriptions.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 08f7ac2...9b58716. Read the comment docs.

@plettich

This comment has been minimized.

Contributor

plettich commented Nov 26, 2018

looks good.

@fredreichbier fredreichbier merged commit 89f3ebc into master Nov 26, 2018

5 checks passed

ci/circleci Your tests passed on CircleCI!
Details
codecov/patch 100% of diff hit (target 96.02%)
Details
codecov/project 96.02% (+0%) compared to 08f7ac2
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@fredreichbier fredreichbier deleted the missing-docs branch Nov 26, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment