New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

redirect to login on reload #1327

Merged
merged 1 commit into from Dec 3, 2018

Conversation

Projects
None yet
2 participants
@cornelinux
Member

cornelinux commented Nov 29, 2018

I we reload we are missing the authorization header.
The server does not return -401 anymore, but error codes
403x.
We add one central error handling function, that redirects
to the login page (or register or reset)

Closes #1326

Merging #1327 into master will not change coverage.
The diff coverage is n/a.
Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1327   +/-   ##
=======================================
Coverage   96.01%   96.01%
=======================================
Files         141      141
Lines       17175    17175
=======================================
Hits        16490    16490
Misses        685      685

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4da61fa...aefde99. Read the comment docs.

  • looks good.

  

redirect to login on reload
I we reload we are missing the authorization header.
The server does not return -401 anymore, but error codes
403x.
We add one central error handling function, that redirects
to the login page (or register or reset)

Closes #1326

@cornelinux cornelinux requested a review from privacyidea/core Nov 29, 2018

@codecov

This comment has been minimized.

codecov bot commented Nov 29, 2018

Codecov Report

Merging #1327 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1327   +/-   ##
=======================================
  Coverage   96.01%   96.01%           
=======================================
  Files         141      141           
  Lines       17175    17175           
=======================================
  Hits        16490    16490           
  Misses        685      685

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4da61fa...aefde99. Read the comment docs.

@plettich

This comment has been minimized.

Contributor

plettich commented Dec 3, 2018

looks good.

@plettich plettich merged commit a2c7103 into master Dec 3, 2018

5 checks passed

ci/circleci Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing 4da61fa...aefde99
Details
codecov/project 96.01% remains the same compared to 4da61fa
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@plettich plettich deleted the 1326/redirect_to_login branch Dec 3, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment