New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation for no_auth_counter #1350

Merged
merged 2 commits into from Dec 20, 2018

Conversation

Projects
None yet
2 participants
@cornelinux
Copy link
Member

cornelinux commented Dec 20, 2018

Closes #1339

Merging #1350 into master will increase coverage by 0.07%.
The diff coverage is n/a.
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1350      +/-   ##
==========================================
+ Coverage   96.38%   96.45%   +0.07%
==========================================
Files         144      144
Lines       17322    17731     +409
==========================================
+ Hits        16696    17103     +407
- Misses        626      628       +2
Impacted Files Coverage Δ
privacyidea/lib/token.py 96.39% <0%> (+1.46%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b617a19...c14b1a2. Read the comment docs.

  • Sorry. Two issues in one PR.
    Also
    Closes #1299

  

@cornelinux cornelinux requested a review from privacyidea/core Dec 20, 2018

@plettich
Copy link
Contributor

plettich left a comment

looks good.

@codecov

This comment has been minimized.

Copy link

codecov bot commented Dec 20, 2018

Codecov Report

Merging #1350 into master will increase coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1350      +/-   ##
==========================================
+ Coverage   96.38%   96.45%   +0.07%     
==========================================
  Files         144      144              
  Lines       17322    17731     +409     
==========================================
+ Hits        16696    17103     +407     
- Misses        626      628       +2
Impacted Files Coverage Δ
privacyidea/lib/token.py 96.39% <0%> (+1.46%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b617a19...fff0db0. Read the comment docs.

Fix the initial description of the appliance
The old docs referenced privacyidea-setup.
This does not exist anymore and is the
privacyidea-appliance in a new repository.

Closes #1339
@cornelinux

This comment has been minimized.

Copy link
Member

cornelinux commented Dec 20, 2018

Sorry. Two issues in one PR.
Also
Closes #1299

@plettich
Copy link
Contributor

plettich left a comment

still looks good.

@cornelinux cornelinux merged commit 69e612b into master Dec 20, 2018

1 of 3 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details
ci/circleci Your tests passed on CircleCI!
Details

@cornelinux cornelinux deleted the 1339/doc_no_auth_counter branch Dec 20, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment