New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add check for client_component #1351

Merged
merged 2 commits into from Jan 2, 2019

Conversation

Projects
None yet
2 participants
@cornelinux
Copy link
Member

cornelinux commented Dec 20, 2018

Closes #1347

Merging #1351 into master will decrease coverage by 0.01%.
The diff coverage is n/a.
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1351      +/-   ##
==========================================
- Coverage   96.38%   96.37%   -0.02%
==========================================
Files         144      144
Lines       17322    17322
==========================================
- Hits        16696    16694       -2
- Misses        626      628       +2
Impacted Files Coverage Δ
privacyidea/lib/tokens/u2f.py 94.16% <0%> (-1.67%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 69e612b...db1119c. Read the comment docs.

  

@cornelinux cornelinux requested a review from fredreichbier Dec 20, 2018

@codecov

This comment has been minimized.

Copy link

codecov bot commented Dec 20, 2018

Codecov Report

Merging #1351 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1351   +/-   ##
=======================================
  Coverage   96.64%   96.64%           
=======================================
  Files         144      144           
  Lines       17291    17291           
=======================================
  Hits        16711    16711           
  Misses        580      580

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 42a210c...11291d2. Read the comment docs.

@fredreichbier fredreichbier merged commit 7a7c855 into master Jan 2, 2019

5 checks passed

ci/circleci Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing 42a210c...11291d2
Details
codecov/project 96.64% remains the same compared to 42a210c
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@fredreichbier fredreichbier deleted the 1347/client_component_check branch Jan 2, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment