New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update travis configuration #1362

Merged
merged 1 commit into from Jan 2, 2019

Conversation

Projects
None yet
2 participants
@plettich
Copy link
Contributor

plettich commented Jan 1, 2019

  • switch to pytest as testing framework
  • use python '-b' flag to check for undesired byte conversions
  • add tests/conftest.py to disable tests for specific python versions

  •  General Comment
  • # Codecov Report

Merging #1362 into master will decrease coverage by 0.01%.
The diff coverage is n/a.
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1362      +/-   ##
==========================================
- Coverage   96.64%   96.62%   -0.02%
==========================================
Files         144      144
Lines       17291    17291
==========================================
- Hits        16711    16708       -3
- Misses        580      583       +3
Impacted Files Coverage Δ
privacyidea/lib/tokens/u2f.py 93.33% <0%> (-2.5%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 42a210c...327601f. Read the comment docs.

  •  File: tests/conftest.py:L1-8
  • The sms test is excluded?
    Is there a problem, why this test would not run?
  • We currently have no working smpp library for Python 3 thus the test won't even load.
    This was a mere example of how to exclude tests for specific Python versions. Currently there are several tests failing with Python 3.5/3.6, i have just not added all of them here.
  • OK, I see. These tests are only excluded for python ver > 2.

  

Update travis configuration
- switch to pytest as testing framework
- use python '-b' flag to check for undesired byte conversions
- add `tests/conftest.py` to disable tests for specific python versions

@plettich plettich requested a review from privacyidea/core Jan 1, 2019

@codecov

This comment has been minimized.

Copy link

codecov bot commented Jan 1, 2019

Codecov Report

Merging #1362 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1362      +/-   ##
==========================================
- Coverage   96.64%   96.62%   -0.02%     
==========================================
  Files         144      144              
  Lines       17291    17291              
==========================================
- Hits        16711    16708       -3     
- Misses        580      583       +3
Impacted Files Coverage Δ
privacyidea/lib/tokens/u2f.py 93.33% <0%> (-2.5%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 42a210c...327601f. Read the comment docs.

1 similar comment
@codecov

This comment has been minimized.

Copy link

codecov bot commented Jan 1, 2019

Codecov Report

Merging #1362 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1362      +/-   ##
==========================================
- Coverage   96.64%   96.62%   -0.02%     
==========================================
  Files         144      144              
  Lines       17291    17291              
==========================================
- Hits        16711    16708       -3     
- Misses        580      583       +3
Impacted Files Coverage Δ
privacyidea/lib/tokens/u2f.py 93.33% <0%> (-2.5%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 42a210c...327601f. Read the comment docs.

collect_ignore = []
if sys.version_info[0] > 2:
collect_ignore.append("test_mod_apache.py")
collect_ignore.append("test_lib_smsprovider.py")

This comment has been minimized.

@cornelinux

cornelinux Jan 2, 2019

Member

The sms test is excluded?
Is there a problem, why this test would not run?

This comment has been minimized.

@plettich

plettich Jan 2, 2019

Contributor

We currently have no working smpp library for Python 3 thus the test won't even load.
This was a mere example of how to exclude tests for specific Python versions. Currently there are several tests failing with Python 3.5/3.6, i have just not added all of them here.

This comment has been minimized.

@cornelinux

cornelinux Jan 2, 2019

Member

OK, I see. These tests are only excluded for python ver > 2.

@cornelinux cornelinux merged commit b837f39 into master Jan 2, 2019

4 of 5 checks passed

codecov/project 96.62% (-0.02%) compared to 42a210c
Details
ci/circleci Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing 42a210c...327601f
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@cornelinux cornelinux deleted the travis_check_bytes branch Jan 2, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment