New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add user cache unit test for secondary login attributes #1363

Merged
merged 1 commit into from Jan 7, 2019

Conversation

Projects
None yet
2 participants
@fredreichbier
Copy link
Member

fredreichbier commented Jan 3, 2019

This only adds a missing unit test for #1343 and closes #1354.

Merging #1363 into master will not change coverage.
The diff coverage is n/a.
Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1363   +/-   ##
=======================================
Coverage   96.64%   96.64%
=======================================
Files         144      144
Lines       17291    17291
=======================================
Hits        16711    16711
Misses        580      580

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b837f39...de515a8. Read the comment docs.

  

@fredreichbier fredreichbier requested a review from privacyidea/core Jan 3, 2019

@codecov

This comment has been minimized.

Copy link

codecov bot commented Jan 3, 2019

Codecov Report

Merging #1363 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1363   +/-   ##
=======================================
  Coverage   96.64%   96.64%           
=======================================
  Files         144      144           
  Lines       17291    17291           
=======================================
  Hits        16711    16711           
  Misses        580      580

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b837f39...de515a8. Read the comment docs.

@plettich
Copy link
Contributor

plettich left a comment

looks good.

@plettich plettich merged commit cf89bc0 into master Jan 7, 2019

5 checks passed

ci/circleci Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing b837f39...de515a8
Details
codecov/project 96.64% remains the same compared to b837f39
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@plettich plettich deleted the 1354/user-cache-unit-test branch Jan 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment