New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make lib/machines and machinetokens run on python3 #1410

Merged
merged 1 commit into from Jan 30, 2019

Conversation

Projects
None yet
2 participants
@cornelinux
Copy link
Member

cornelinux commented Jan 30, 2019

Replaces PR #1406
Working on #676

Merging #1410 into master will not change coverage.
The diff coverage is 100%.
Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1410   +/-   ##
=======================================
Coverage   96.77%   96.77%
=======================================
Files         144      144
Lines       17215    17215
=======================================
Hits        16660    16660
Misses        555      555
Impacted Files Coverage Δ
privacyidea/models.py 99.04% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d06948e...e787b5e. Read the comment docs.

  

@cornelinux cornelinux requested review from fredreichbier and plettich Jan 30, 2019

@codecov

This comment has been minimized.

Copy link

codecov bot commented Jan 30, 2019

Codecov Report

Merging #1410 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1410   +/-   ##
=======================================
  Coverage   96.77%   96.77%           
=======================================
  Files         144      144           
  Lines       17215    17215           
=======================================
  Hits        16660    16660           
  Misses        555      555
Impacted Files Coverage Δ
privacyidea/models.py 99.04% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d06948e...e787b5e. Read the comment docs.

@plettich
Copy link
Contributor

plettich left a comment

looks good.

@plettich plettich merged commit e605fb4 into master Jan 30, 2019

5 checks passed

ci/circleci Your tests passed on CircleCI!
Details
codecov/patch 100% of diff hit (target 96.77%)
Details
codecov/project 96.77% (+0%) compared to d06948e
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@plettich plettich deleted the python3-lib-machines2 branch Jan 30, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment