New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python3 lib usercache #1412

Merged
merged 2 commits into from Jan 31, 2019

Conversation

Projects
None yet
2 participants
@cornelinux
Copy link
Member

cornelinux commented Jan 30, 2019


Merging #1412 into master will decrease coverage by 27.51%.
The diff coverage is 100%.
Impacted file tree graph

@@             Coverage Diff             @@
##           master    #1412       +/-   ##
===========================================
- Coverage   96.76%   69.25%   -27.52%
===========================================
Files         144      144
Lines       17215    17214        -1
===========================================
- Hits        16658    11921     -4737
- Misses        557     5293     +4736
Impacted Files Coverage Δ
privacyidea/lib/usercache.py 100% <100%> (ø) ⬆️
privacyidea/lib/pinhandling/base.py 0% <0%> (-100%) ⬇️
privacyidea/lib/tokens/ocra.py 10.34% <0%> (-89.66%) ⬇️
privacyidea/lib/smsprovider/HttpSMSProvider.py 13.91% <0%> (-84.35%) ⬇️
privacyidea/lib/importotp.py 12.2% <0%> (-81.02%) ⬇️
privacyidea/lib/tokens/u2f.py 16.66% <0%> (-77.5%) ⬇️
privacyidea/api/lib/prepolicy.py 20.97% <0%> (-76.7%) ⬇️
privacyidea/lib/apps.py 23.88% <0%> (-76.12%) ⬇️
privacyidea/webui/certificate.py 20% <0%> (-75%) ⬇️
privacyidea/lib/smsprovider/SmppSMSProvider.py 26.92% <0%> (-73.08%) ⬇️
... and 77 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e605fb4...d2f82fc. Read the comment docs.

  

cornelinux added some commits Jan 30, 2019

@cornelinux cornelinux requested review from fredreichbier and plettich Jan 30, 2019

@codecov

This comment has been minimized.

Copy link

codecov bot commented Jan 30, 2019

Codecov Report

Merging #1412 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1412      +/-   ##
==========================================
+ Coverage   96.76%   96.77%   +0.01%     
==========================================
  Files         144      144              
  Lines       17215    17215              
==========================================
+ Hits        16658    16660       +2     
+ Misses        557      555       -2
Impacted Files Coverage Δ
privacyidea/lib/usercache.py 100% <100%> (ø) ⬆️
privacyidea/lib/tokens/u2f.py 95.83% <0%> (+1.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e605fb4...d2f82fc. Read the comment docs.

@plettich
Copy link
Contributor

plettich left a comment

looks good.

@plettich plettich merged commit 1d96a9a into master Jan 31, 2019

5 checks passed

ci/circleci Your tests passed on CircleCI!
Details
codecov/patch 100% of diff hit (target 96.76%)
Details
codecov/project 96.77% (+0.01%) compared to e605fb4
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@plettich plettich deleted the python3-lib-usercache branch Jan 31, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment