New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate EMail, TAN and VASCO token to Python 3 #1417

Merged
merged 1 commit into from Feb 1, 2019

Conversation

Projects
None yet
2 participants
@fredreichbier
Copy link
Member

fredreichbier commented Feb 1, 2019

This slightly changes behavior: The VASCO token initialization now throws a ParameterError if the secret couldn't be decoded.

@fredreichbier fredreichbier requested a review from privacyidea/core Feb 1, 2019

@codecov

This comment has been minimized.

Copy link

codecov bot commented Feb 1, 2019

Codecov Report

Merging #1417 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1417      +/-   ##
==========================================
- Coverage   96.78%   96.78%   -0.01%     
==========================================
  Files         144      144              
  Lines       17180    17185       +5     
==========================================
+ Hits        16628    16632       +4     
- Misses        552      553       +1
Impacted Files Coverage Δ
privacyidea/lib/tokens/vascotoken.py 93.84% <100%> (+0.29%) ⬆️
privacyidea/lib/tokens/emailtoken.py 100% <100%> (ø) ⬆️
privacyidea/lib/tokens/tantoken.py 100% <100%> (ø) ⬆️
privacyidea/lib/tokens/vasco.py 96.72% <100%> (-1.64%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 333d704...6ae65d0. Read the comment docs.

@cornelinux cornelinux merged commit 911ac0d into master Feb 1, 2019

5 checks passed

ci/circleci Your tests passed on CircleCI!
Details
codecov/patch 100% of diff hit (target 96.78%)
Details
codecov/project Absolute coverage decreased by -<.01% but relative coverage increased by +3.21% compared to 333d704
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@cornelinux cornelinux deleted the python3_tokens_email_tan_vasco branch Feb 1, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment