New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix enrollment form #1422

Merged
merged 1 commit into from Feb 5, 2019

Conversation

Projects
None yet
2 participants
@Mipronimo
Copy link
Member

Mipronimo commented Feb 4, 2019

If the user has no phone number or email address, the entered value will not be replaced.
Fixes #1419

@codecov

This comment has been minimized.

Copy link

codecov bot commented Feb 4, 2019

Codecov Report

Merging #1422 into master will increase coverage by 0.1%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #1422     +/-   ##
=========================================
+ Coverage   96.78%   96.89%   +0.1%     
=========================================
  Files         144      144             
  Lines       17183    17564    +381     
=========================================
+ Hits        16631    17018    +387     
+ Misses        552      546      -6
Impacted Files Coverage Δ
privacyidea/lib/tokens/hotptoken.py 100% <0%> (ø) ⬆️
privacyidea/lib/apps.py 100% <0%> (ø) ⬆️
privacyidea/lib/utils.py 98.36% <0%> (+1.51%) ⬆️
privacyidea/lib/tokens/u2f.py 95.83% <0%> (+2.5%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4133f5e...5d21351. Read the comment docs.

@cornelinux cornelinux merged commit 98ccbb1 into master Feb 5, 2019

5 checks passed

ci/circleci Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing 4133f5e...5d21351
Details
codecov/project 96.89% (+0.1%) compared to 4133f5e
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@cornelinux cornelinux deleted the 1419/fixEnrollForm branch Feb 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment