New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python3 update passwd remote token tests #1429

Merged
merged 5 commits into from Feb 14, 2019

Conversation

Projects
None yet
3 participants
@plettich
Copy link
Contributor

plettich commented Feb 6, 2019

Working on #676

@plettich plettich requested a review from privacyidea/core Feb 6, 2019

@codecov

This comment has been minimized.

Copy link

codecov bot commented Feb 6, 2019

Codecov Report

Merging #1429 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1429      +/-   ##
==========================================
+ Coverage   96.81%   96.81%   +<.01%     
==========================================
  Files         144      144              
  Lines       17188    17182       -6     
==========================================
- Hits        16640    16635       -5     
+ Misses        548      547       -1
Impacted Files Coverage Δ
privacyidea/lib/tokens/registrationtoken.py 97.87% <100%> (+0.04%) ⬆️
privacyidea/lib/tokens/remotetoken.py 99.06% <100%> (+0.8%) ⬆️
privacyidea/lib/tokens/passwordtoken.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8bd209c...91c57a2. Read the comment docs.


remoteServer = self.get_tokeninfo("remote.server") or ""
remoteServer = remoteServer.encode("utf-8")

# in preparation of the ability to relocate privacyidea urls,
# we introduce the remote url path
remotePath = self.get_tokeninfo("remote.path") or ""

This comment has been minimized.

@fredreichbier

fredreichbier Feb 6, 2019

Member

With this change, removePath is not stripped anymore. I'm not sure it's necessary?

This comment has been minimized.

@plettich

plettich Feb 6, 2019

Author Contributor

Oh, totally missed that. Will ad a test for remote.path as well.

This comment has been minimized.

@cornelinux

cornelinux Feb 7, 2019

Member

The background is, that the remote privacyIDEA server could run e.g. at https://remote.example.com/pi2 while the originial privacyIDEA server would run at https://local.exampl.com/

This comment has been minimized.

@plettich

plettich Feb 7, 2019

Author Contributor

Fixed in 6141b19

This comment has been minimized.

@fredreichbier
Fix remarks from review
- update remote token test case to have a remote token with a different
  remote.path

fredreichbier and others added some commits Feb 12, 2019

@fredreichbier fredreichbier merged commit 6ff90a1 into master Feb 14, 2019

5 checks passed

ci/circleci Your tests passed on CircleCI!
Details
codecov/patch 100% of diff hit (target 96.81%)
Details
codecov/project 96.81% (+<.01%) compared to 8bd209c
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@fredreichbier fredreichbier deleted the python3_update_passwd_remote_token_tests branch Feb 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment