Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tokenowner migration script for tokens with multiple realms #1486

Merged
merged 3 commits into from Mar 7, 2019

Conversation

Projects
None yet
2 participants
@fredreichbier
Copy link
Member

fredreichbier commented Mar 5, 2019

See #1485: Due to a query typo, the migration script aborted whenever it encountered a token with multiple realms. This PR fixes the issue. Also, this fixes various error messages.

Finally, with this PR, the migration script does not create TokenOwner entries with realm=NULL anymore. If the token owner realm cannot be uniquely identified, the migration script does not create a TokenOwner entry at all.

@fredreichbier fredreichbier requested a review from privacyidea/core Mar 5, 2019

@codecov

This comment has been minimized.

Copy link

codecov bot commented Mar 6, 2019

Codecov Report

Merging #1486 into master will increase coverage by 0.11%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #1486      +/-   ##
=========================================
+ Coverage   96.69%   96.8%   +0.11%     
=========================================
  Files         144     144              
  Lines       17249   17249              
=========================================
+ Hits        16679   16698      +19     
+ Misses        570     551      -19
Impacted Files Coverage Δ
privacyidea/lib/crypto.py 95.91% <0%> (+0.34%) ⬆️
privacyidea/lib/utils.py 98.04% <0%> (+0.43%) ⬆️
privacyidea/lib/subscriptions.py 88.09% <0%> (+0.79%) ⬆️
privacyidea/lib/security/default.py 97.77% <0%> (+1.66%) ⬆️
privacyidea/lib/log.py 50.68% <0%> (+16.43%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 72cab0f...0aee4dd. Read the comment docs.

@plettich
Copy link
Member

plettich left a comment

looks good.

@plettich plettich merged commit 0645e8b into master Mar 7, 2019

5 checks passed

ci/circleci Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing 72cab0f...0aee4dd
Details
codecov/project 96.8% (+0.11%) compared to 72cab0f
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.