Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate migration scripts to Python 3 #1488

Merged
merged 3 commits into from Mar 7, 2019

Conversation

Projects
None yet
2 participants
@fredreichbier
Copy link
Member

fredreichbier commented Mar 6, 2019

The necessary changes are due to the "new" except ... as syntax, and due to the missing message attribute for Exceptions. The alternative args[0] should work under both Python 2 and 3.

@fredreichbier fredreichbier requested review from plettich and privacyidea/core Mar 6, 2019

@fredreichbier

This comment has been minimized.

Copy link
Member Author

fredreichbier commented Mar 6, 2019

Whoops, just noticed that actually breaks Python 2 compatibility :-)

@codecov

This comment has been minimized.

Copy link

codecov bot commented Mar 6, 2019

Codecov Report

Merging #1488 into master will increase coverage by 0.11%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #1488      +/-   ##
=========================================
+ Coverage   96.69%   96.8%   +0.11%     
=========================================
  Files         144     144              
  Lines       17249   17249              
=========================================
+ Hits        16679   16698      +19     
+ Misses        570     551      -19
Impacted Files Coverage Δ
privacyidea/lib/crypto.py 95.91% <0%> (+0.34%) ⬆️
privacyidea/lib/utils.py 98.04% <0%> (+0.43%) ⬆️
privacyidea/lib/subscriptions.py 88.09% <0%> (+0.79%) ⬆️
privacyidea/lib/security/default.py 97.77% <0%> (+1.66%) ⬆️
privacyidea/lib/log.py 50.68% <0%> (+16.43%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 72cab0f...0b7a00e. Read the comment docs.

@fredreichbier

This comment has been minimized.

Copy link
Member Author

fredreichbier commented Mar 6, 2019

Pushed a commit that fixes the migration scripts for Python 2.

@plettich
Copy link
Member

plettich left a comment

looks good

@plettich plettich merged commit 501a8f7 into master Mar 7, 2019

2 of 3 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@plettich plettich deleted the python3_migrate_migration branch Mar 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.