Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more debug information for PIN length #1502

Merged
merged 1 commit into from Mar 14, 2019

Conversation

Projects
None yet
2 participants
@cornelinux
Copy link
Member

cornelinux commented Mar 14, 2019

In certain debug scenarios it is important to know the length of
the OTP valu and the OTP Pin.

Closes #1501

Add more debug information for PIN length
In certain debug scenarios it is important to know the length of
the OTP valu and the OTP Pin.

Closes #1501

@cornelinux cornelinux requested a review from privacyidea/core Mar 14, 2019

@codecov

This comment has been minimized.

Copy link

codecov bot commented Mar 14, 2019

Codecov Report

Merging #1502 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #1502      +/-   ##
=========================================
+ Coverage    96.8%   96.8%   +<.01%     
=========================================
  Files         144     144              
  Lines       17250   17253       +3     
=========================================
+ Hits        16699   16702       +3     
  Misses        551     551
Impacted Files Coverage Δ
privacyidea/lib/tokenclass.py 98.77% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c89c545...10dd6ec. Read the comment docs.

@plettich
Copy link
Member

plettich left a comment

looks good

@plettich plettich merged commit 51f12d5 into master Mar 14, 2019

5 checks passed

ci/circleci Your tests passed on CircleCI!
Details
codecov/patch 100% of diff hit (target 96.8%)
Details
codecov/project 96.8% (+<.01%) compared to c89c545
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@plettich plettich deleted the 1501/more-debug-for-pin-length branch Mar 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.