Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase failcounter in case of wrong response to challenge #1546

Merged
merged 1 commit into from Apr 1, 2019

Conversation

Projects
None yet
2 participants
@cornelinux
Copy link
Member

commented Mar 29, 2019

Fixes #1539

@cornelinux cornelinux requested a review from privacyidea/core Mar 29, 2019

@codecov

This comment has been minimized.

Copy link

commented Mar 29, 2019

Codecov Report

Merging #1546 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1546      +/-   ##
==========================================
+ Coverage   96.97%   96.98%   +<.01%     
==========================================
  Files         148      148              
  Lines       17678    17689      +11     
==========================================
+ Hits        17144    17155      +11     
  Misses        534      534
Impacted Files Coverage Δ
privacyidea/lib/token.py 95.87% <100%> (+0.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f8ead4c...e2a1c28. Read the comment docs.

1 similar comment
@codecov

This comment has been minimized.

Copy link

commented Mar 29, 2019

Codecov Report

Merging #1546 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1546      +/-   ##
==========================================
+ Coverage   96.97%   96.98%   +<.01%     
==========================================
  Files         148      148              
  Lines       17678    17689      +11     
==========================================
+ Hits        17144    17155      +11     
  Misses        534      534
Impacted Files Coverage Δ
privacyidea/lib/token.py 95.87% <100%> (+0.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f8ead4c...e2a1c28. Read the comment docs.

@plettich
Copy link
Member

left a comment

looks good.

@plettich plettich merged commit 981e3fc into master Apr 1, 2019

5 checks passed

ci/circleci Your tests passed on CircleCI!
Details
codecov/patch 100% of diff hit (target 96.97%)
Details
codecov/project 96.98% (+<.01%) compared to f8ead4c
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@plettich

This comment has been minimized.

Copy link
Member

commented Apr 1, 2019

Should we add this to 2.23 as well?

@cornelinux

This comment has been minimized.

Copy link
Member Author

commented Apr 1, 2019

I currently do not think so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.