Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix requirements for virtualenv #1551

Merged
merged 2 commits into from Apr 8, 2019

Conversation

Projects
None yet
3 participants
@plettich
Copy link
Member

commented Apr 2, 2019

(re)moved some requirements

@plettich plettich requested a review from privacyidea/core Apr 2, 2019

@codecov

This comment has been minimized.

Copy link

commented Apr 2, 2019

Codecov Report

Merging #1551 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1551   +/-   ##
=======================================
  Coverage   96.97%   96.97%           
=======================================
  Files         148      148           
  Lines       17680    17680           
=======================================
  Hits        17146    17146           
  Misses        534      534

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 46d678c...d4ae164. Read the comment docs.

@cornelinux
Copy link
Member

left a comment

Please lets discuss the dependencies for database connectors.

Show resolved Hide resolved requirements.txt
Show resolved Hide resolved requirements.txt Outdated
Show resolved Hide resolved requirements.txt Outdated
Fix remarks from review
- Pin requirements to specific versions in requirements files
- Add several packages which are requirements of other required packages
- Remove `argparse` package since it is part of the python standard
  library
- Bump version of `psycopg2` to be able to build on ubuntu 18.04

@plettich plettich force-pushed the 1550/fix_requirements branch from 65c5268 to d4ae164 Apr 5, 2019

@plettich plettich marked this pull request as ready for review Apr 5, 2019

passlib==1.7.1
Pillow==5.1.0
psycopg2>=2.6

This comment has been minimized.

Copy link
@cornelinux

cornelinux Apr 8, 2019

Member

I would like to have psycopg2 in the ubuntu packages.
To my understanding this would have to be compiled if installed manually in a virtualenv?
So we obviously should patch this into ubuntu packages but not have this in the requirements.txt?

@cornelinux cornelinux merged commit 5811bf8 into master Apr 8, 2019

5 checks passed

ci/circleci Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing 46d678c...d4ae164
Details
codecov/project 96.97% remains the same compared to 46d678c
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.