Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt install information for 3.0 #1553

Merged
merged 3 commits into from Apr 3, 2019

Conversation

Projects
None yet
3 participants
@cornelinux
Copy link
Member

commented Apr 3, 2019

Add information about other ubuntu packages
add info about stamping

Working on #1489

Adapt install information for 3.0
Add information about other ubuntu packages
add info about stamping

Working on #1489

@cornelinux cornelinux requested review from fredreichbier and plettich Apr 3, 2019

@codecov

This comment has been minimized.

Copy link

commented Apr 3, 2019

Codecov Report

Merging #1553 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1553   +/-   ##
=======================================
  Coverage   96.97%   96.97%           
=======================================
  Files         148      148           
  Lines       17680    17680           
=======================================
  Hits        17146    17146           
  Misses        534      534

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6c496c0...7032b87. Read the comment docs.

Show resolved Hide resolved doc/installation/ubuntu.rst Outdated
Show resolved Hide resolved doc/installation/ubuntu.rst Outdated
Show resolved Hide resolved doc/installation/ubuntu.rst Outdated
Show resolved Hide resolved doc/installation/ubuntu.rst Outdated
Show resolved Hide resolved doc/installation/ubuntu.rst Outdated

cornelinux and others added some commits Apr 3, 2019

@fredreichbier

This comment has been minimized.

Copy link
Member

commented Apr 3, 2019

The changes look good to me. But as we discussed in #1127, should we also add a note to the upgrade documentation for pip installations that one can use pip install -r lib/privacyidea/requirements.txt to pin dependencies to the tested versions?

@cornelinux

This comment has been minimized.

Copy link
Member Author

commented Apr 3, 2019

@fredreichbier: I actually added the pinning in the documentation! in d69da2f

@fredreichbier

This comment has been minimized.

Copy link
Member

commented Apr 3, 2019

Instead of adding a hint, we change the behavior of privacyidea-pip-update. I opened #1555 for that.

@fredreichbier fredreichbier merged commit 4e1d114 into master Apr 3, 2019

5 checks passed

ci/circleci Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing 6c496c0...7032b87
Details
codecov/project 96.97% remains the same compared to 6c496c0
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@fredreichbier fredreichbier deleted the 1489/install-instructions branch Apr 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.