Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add translation for push token #1557

Merged
merged 4 commits into from Apr 6, 2019

Conversation

Projects
None yet
4 participants
@cornelinux
Copy link
Member

commented Apr 4, 2019

No description provided.

@codecov

This comment has been minimized.

Copy link

commented Apr 4, 2019

Codecov Report

Merging #1557 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1557   +/-   ##
=======================================
  Coverage   96.97%   96.97%           
=======================================
  Files         148      148           
  Lines       17680    17680           
=======================================
  Hits        17146    17146           
  Misses        534      534
Impacted Files Coverage Δ
privacyidea/lib/smsprovider/FirebaseProvider.py 100% <ø> (ø) ⬆️
privacyidea/lib/eventhandler/base.py 95.96% <ø> (ø) ⬆️
privacyidea/lib/tokens/pushtoken.py 97.28% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 46d678c...54eed0a. Read the comment docs.

#: lib/eventhandler/base.py:129
#: lib/eventhandler/base.py:137
msgid "The user resolver, for which this event should apply."
msgstr "Der Resolver des Benutzers, für den diese Ereignis-Definition greift."

This comment has been minimized.

Copy link
@nilsbehlen

nilsbehlen Apr 4, 2019

Contributor

The user resolver = Der Benutzerresolver
The user's resolver = Der Resolver des Benutzers
maybe add the 's or change the translation to preempt ambiguity

This comment has been minimized.

Copy link
@cornelinux

cornelinux Apr 5, 2019

Author Member

Thats true, I will change it to the "resolver of the user".
Especially since there is no "token resolver"; but "the resolver of the token" makes perfect sense.

This comment has been minimized.

Copy link
@cornelinux

cornelinux Apr 5, 2019

Author Member

done

#: lib/eventhandler/base.py:135
#: lib/eventhandler/base.py:148
msgid "The token resolver, for which this event should apply."
msgstr "Der Resolver des Tokens, für den diese Ereignis-Definition greift."

This comment has been minimized.

Copy link
@nilsbehlen

nilsbehlen Apr 4, 2019

Contributor

see above

This comment has been minimized.

Copy link
@cornelinux

cornelinux Apr 5, 2019

Author Member

done

msgid "Your LDAP config seems to be OK, {0!s} user objects found."
msgstr "Die LDAP-Konfiguration scheint in Ordnung zu sein. Es wurden {0!s} Benutzerobjekte gefunden."

#: lib/smsprovider/FirebaseProvider.py:114
msgid "The URL the Push App should contact in the second enrollment step. Usually it is the endpoint /ttype/push of the privacyIDEA server."
msgstr "Die URL für den zweiten Ausrollschritt. Diese URL ruft das Smartphone auf, nachdem der Benutzer den QR-Code gescannt hat. Überlicher Weise ist das der Endpunkt /ttype/push des privacyIDEA Servers."

This comment has been minimized.

Copy link
@nilsbehlen

nilsbehlen Apr 4, 2019

Contributor

Üblicherweise

This comment has been minimized.

Copy link
@cornelinux

cornelinux Apr 5, 2019

Author Member

done

msgstr "Die URL für den zweiten Ausrollschritt. Diese URL ruft das Smartphone auf, nachdem der Benutzer den QR-Code gescannt hat. Überlicher Weise ist das der Endpunkt /ttype/push des privacyIDEA Servers."

#: lib/smsprovider/FirebaseProvider.py:118
msgid "How long should the second step of the enrollment be accepted (in minutes)."

This comment has been minimized.

Copy link
@nilsbehlen

nilsbehlen Apr 4, 2019

Contributor

How long the second step of enrollment should be accepted in ((in) minutes).

This comment has been minimized.

Copy link
@cornelinux

cornelinux Apr 4, 2019

Author Member

@nilsbehlen I do not understand the double "in"'s

This comment has been minimized.

Copy link
@nilsbehlen

nilsbehlen Apr 5, 2019

Contributor

@cornelinux the first "in" has to be there and the second could be optional, could also just be "minutes"

This comment has been minimized.

Copy link
@cornelinux

cornelinux Apr 5, 2019

Author Member

OK: For how long is the second step during rollout accepted (in minutes)

This comment has been minimized.

Copy link
@cornelinux

cornelinux Apr 5, 2019

Author Member

done in 71bf8d4


#: lib/smsprovider/FirebaseProvider.py:126
msgid "The project number, that the client should use. Get it from your Firebase console."
msgstr "Die Firebase Projekt Nummber. Diese finden Sie in Ihrer Firebase Konsole."

This comment has been minimized.

Copy link
@nilsbehlen

nilsbehlen Apr 4, 2019

Contributor

Projektnummer

This comment has been minimized.

Copy link
@cornelinux

cornelinux Apr 5, 2019

Author Member

done

msgstr "Die Firebase App ID. Diese finden Sie in Ihrer Firebase Konsole."

#: lib/smsprovider/FirebaseProvider.py:136
msgid "The API KEY, that the client should use. Get it from your Firebase console."

This comment has been minimized.

Copy link
@nilsbehlen

nilsbehlen Apr 4, 2019

Contributor

Key

This comment has been minimized.

Copy link
@cornelinux

cornelinux Apr 5, 2019

Author Member

done

msgstr "Die Firebase Projekt Nummber. Diese finden Sie in Ihrer Firebase Konsole."

#: lib/smsprovider/FirebaseProvider.py:131
msgid "The APP ID, that the client should use. Get it from your Firebase console."

This comment has been minimized.

Copy link
@nilsbehlen

nilsbehlen Apr 4, 2019

Contributor

App

This comment has been minimized.

Copy link
@cornelinux

cornelinux Apr 5, 2019

Author Member

done


#: lib/smsprovider/FirebaseProvider.py:118
msgid "How long should the second step of the enrollment be accepted (in minutes)."
msgstr "Die Zeit, für die die Antwort im zweiten Schritt beim Ausrollen akzeptiert wird (in Minuten)."

This comment has been minimized.

Copy link
@nilsbehlen

nilsbehlen Apr 4, 2019

Contributor

Die Zeit, in der die Anwort im zweiten Schritt des Ausrollens (noch) akzeptiert wird (in Minuten).

This comment has been minimized.

Copy link
@cornelinux

cornelinux Apr 5, 2019

Author Member

done.

msgstr "Bitte bestätigen Sie die Anmeldung auf Ihrem Mobilgerät!"

#: lib/tokens/pushtoken.py:65
msgid "Do you want to confirm login?"

This comment has been minimized.

Copy link
@nilsbehlen

nilsbehlen Apr 4, 2019

Contributor

"Do you want to confirm the login?"

This comment has been minimized.

Copy link
@cornelinux

cornelinux Apr 5, 2019

Author Member

Done

@nilsbehlen
Copy link
Contributor

left a comment

see comments

Show resolved Hide resolved po/de.po Outdated
Show resolved Hide resolved po/template.pot Outdated

@cornelinux cornelinux requested review from nilsbehlen and plettich Apr 5, 2019

Show resolved Hide resolved po/de.po Outdated
Show resolved Hide resolved privacyidea/translations/de/LC_MESSAGES/messages.po Outdated

@cornelinux cornelinux merged commit 8b1ff6f into master Apr 6, 2019

5 checks passed

ci/circleci Your tests passed on CircleCI!
Details
codecov/patch 100% of diff hit (target 96.97%)
Details
codecov/project 96.97% (+0%) compared to 46d678c
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.